-
Notifications
You must be signed in to change notification settings - Fork 1
Docs: test #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Docs: test #1
Conversation
| # npm | ||
| package-lock.json | ||
| # yarn | ||
| #package-lock.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok!!
docs/project/contribute.md
Outdated
|
|
||
| `node -v` | ||
|
|
||
| Install the newest (deprecated) version of Docusaurus: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason that the deprecated version is being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs haven't been updated in a very long time! The docs are built using docusaurus. However they were built using version 1.x and now 3.x is out. I want to wait to upgrade to 3.x is there is some translation infrastructure setup with crowdin and those files link to pages in the documentation.
However, if we upgrade to 3.x, the directory structure of the docs changes, and that will break translations! So i want access to crowdin FIRST before we upgrade!
I will create a more comprehensive issue about this in the all-contribs repo and tag you so you can review and advise if you think there are better paths. ❤️
|
Linting is now fixed - i pulled the file in from here it had nothing to do with my pr! |
No description provided.